fix(ama-sdk): support of URL as spec-path input #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c7a2586. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
kpanot
force-pushed
the
bugfix/spec-urls
branch
from
135d844
to
1d4fbaa
Compare
github-actions
bot
added
bug
kpanot
force-pushed
the
bugfix/spec-urls
branch
2 times, most recently
from
e669b21
to
67f5da1
Compare
kpanot
force-pushed
the
bugfix/spec-urls
branch
4 times, most recently
from
9d97240
to
31edbac
Compare
packages/@ama-sdk/schematics/schematics/code-generator/code-generator.ts
Show resolved
Hide resolved
cpaulve-1A
reviewed
Apr 4, 2024
cpaulve-1A
reviewed
Apr 4, 2024
...es/@ama-sdk/schematics/schematics/typescript/shell/templates/base/openapitools.json.template
Show resolved
Hide resolved
fpaul-1A
previously approved these changes
Apr 5, 2024
cpaulve-1A
approved these changes
Apr 5, 2024
cpaulve-1A
requested changes
Apr 9, 2024
kpanot
force-pushed
the
bugfix/spec-urls
branch
from
7c3ce9f
to
77e4e99
Compare
|
the documentation should be updated to reflect the changes. |
fpaul-1A
previously approved these changes
Apr 10, 2024
kpanot
force-pushed
the
bugfix/spec-urls
branch
from
77e4e99
to
c3b6fb9
Compare
cpaulve-1A
reviewed
Apr 11, 2024
cpaulve-1A
reviewed
Apr 11, 2024
cpaulve-1A
reviewed
Apr 11, 2024
sdo-1A
reviewed
Apr 15, 2024
kpanot
force-pushed
the
bugfix/spec-urls
branch
3 times, most recently
from
af29166
to
8052609
Compare
sdo-1A
reviewed
Apr 15, 2024
fpaul-1A
previously approved these changes
Apr 15, 2024
vscaiceanu-1a
previously approved these changes
Apr 15, 2024
mrednic-1A
reviewed
Apr 15, 2024
kpanot
force-pushed
the
bugfix/spec-urls
branch
from
8052609
to
c7a2586
Compare
cpaulve-1A
reviewed
Apr 16, 2024
| ```json5 | ||
| { | ||
| // ... | ||
| "generate": "yarn schematics @ama-sdk/schematics:typescript-core --spec-path ./openapi-spec.yaml", |
There was a problem hiding this comment.
We probably need to update it in the config we generate with the shell
cpaulve-1A
approved these changes
Apr 16, 2024
vscaiceanu-1a
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Support of URL and JSON based specification.